Merge pull request #1515 from pkese/fix-worldbank-url

Change WorldBank url to https; fixes #1514
fsprojects · Oct 2, 2024 · 90796ba · 90796ba
2 parents 71c95c7 + 07fb089
commit 90796ba
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/library/JsonProvider.fsx b/docs/library/JsonProvider.fsx
@@ -306,7 +306,7 @@ let doc = WorldBank.GetSample()
 (** Note that we can also load the data directly from the web both in the `Load` method and in
 the type provider sample parameter, and there's an asynchronous `AsyncLoad` method available too: *)
 let wbReq =
-    "http://api.worldbank.org/country/cz/indicator/"
+    "https://api.worldbank.org/country/cz/indicator/"
     + "GC.DOD.TOTL.GD.ZS?format=json"
 
 let docAsync = WorldBank.AsyncLoad(wbReq)

diff --git a/docs/library/JsonValue.fsx b/docs/library/JsonValue.fsx
@@ -147,7 +147,7 @@ let value = JsonValue.Load(__SOURCE_DIRECTORY__ + "../../data/WorldBank.json")
 asynchronous version available too: *)
 
 let wbReq =
-    "http://api.worldbank.org/country/cz/indicator/"
+    "https://api.worldbank.org/country/cz/indicator/"
     + "GC.DOD.TOTL.GD.ZS?format=json"
 
 let valueAsync = JsonValue.AsyncLoad(wbReq)

diff --git a/src/FSharp.Data.DesignTime/WorldBank/WorldBankProvider.fs b/src/FSharp.Data.DesignTime/WorldBank/WorldBankProvider.fs
@@ -28,7 +28,7 @@ type public WorldBankProvider(cfg: TypeProviderConfig) as this =
     let asm = System.Reflection.Assembly.GetExecutingAssembly()
     let ns = "FSharp.Data"
 
-    let defaultServiceUrl = "http://api.worldbank.org/v2"
+    let defaultServiceUrl = "https://api.worldbank.org/v2"
     let cacheDuration = TimeSpan.FromDays 30.0
     let restCache = createInternetFileCache "WorldBankSchema" cacheDuration
 

diff --git a/...xpected/WorldBank,World Development Indicators;Global Financial Development,True.expected b/...xpected/WorldBank,World Development Indicators;Global Financial Development,True.expected
@@ -1,6 +1,6 @@
 class WorldBankDataProvider : obj
     static member GetDataContext: () -> WorldBankDataProvider+ServiceTypes+WorldBankDataService
-    (new WorldBankData("http://api.worldbank.org", "World Development Indicators;Global Financial Development"))
+    (new WorldBankData("https://api.worldbank.org", "World Development Indicators;Global Financial Development"))
 
 
 class WorldBankDataProvider+ServiceTypes : obj