Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fsdocs-tool to v20 stable #1504

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Mar 13, 2024

After build spending around 6h in document generation, there was an idea to update the fsdocs-tool:
#1496 (comment)

@nojaf
Copy link
Contributor

nojaf commented Mar 13, 2024

It seems to get stuck on generating model for docs\library\JsonProvider.fsx --> .\library\JsonProvider.html.

@Thorium
Copy link
Member Author

Thorium commented Mar 13, 2024

It does work on Ubuntu CI, and it does work on local Windows.
It could be multiple things, e.g.:

  • Some network-request blocked
  • Some source code issue (but why would it work locally?)
  • Something incorrect in the comment-syntax (but it looks a lot like CsvProvider.fsx which does work)

Edit: I tested to disconnect my local computer from the internet and JsonProvider.fsx generation still worked.

@nojaf
Copy link
Contributor

nojaf commented Mar 13, 2024

I can't build on my Windows, so can't tell what is up.

@Thorium
Copy link
Member Author

Thorium commented Mar 13, 2024

Now it works.

Either:

  • The >> was too acidic for the fsdocs-tool, or
  • the array-indexing without . was too recent syntax for this project.

Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, I'm surprised fsdocs would not like this, but hey, if it unblocks us then it unblocks us. Thanks so much for digging into this @Thorium

@cartermp cartermp merged commit 674cacf into fsprojects:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants