-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS-225]: Add Sort Feature To Household List #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FS-225 Add Sort Feature to Household List
Story
Technical DetailSorting should happen on API, not the client side. Suggested Libraryhttps://icflorescu.github.io/mantine-datatable/examples/sorting |
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erfan-goodarzi
had a problem deploying
to
Preview
August 9, 2023 10:27
— with
GitHub Actions
Failure
erfan-goodarzi
had a problem deploying
to
Chromatic
August 9, 2023 10:27
— with
GitHub Actions
Failure
erfan-goodarzi
had a problem deploying
to
Chromatic
August 9, 2023 18:53
— with
GitHub Actions
Failure
erfan-goodarzi
had a problem deploying
to
Preview
August 9, 2023 18:53
— with
GitHub Actions
Failure
ASafaeirad
requested changes
Aug 9, 2023
app/pages/Dashboard/Households/HouseholdActionButton/HouseholdActionButton.tsx
Outdated
Show resolved
Hide resolved
erfan-goodarzi
force-pushed
the
fs-225-add-sort-feature-to-household-list
branch
from
August 11, 2023 12:20
da7d249
to
76f64b5
Compare
erfan-goodarzi
had a problem deploying
to
Chromatic
August 11, 2023 12:20
— with
GitHub Actions
Failure
erfan-goodarzi
had a problem deploying
to
Preview
August 11, 2023 12:20
— with
GitHub Actions
Failure
erfan-goodarzi
force-pushed
the
fs-225-add-sort-feature-to-household-list
branch
from
August 14, 2023 09:50
514913d
to
f5be35d
Compare
erfan-goodarzi
temporarily deployed
to
Chromatic
August 14, 2023 09:50
— with
GitHub Actions
Inactive
erfan-goodarzi
had a problem deploying
to
Preview
August 14, 2023 09:50
— with
GitHub Actions
Failure
erfan-goodarzi
had a problem deploying
to
Preview
August 15, 2023 11:12
— with
GitHub Actions
Failure
erfan-goodarzi
temporarily deployed
to
Chromatic
August 15, 2023 11:12
— with
GitHub Actions
Inactive
ASafaeirad
approved these changes
Aug 21, 2023
ASafaeirad
added a commit
that referenced
this pull request
Aug 25, 2023
This PR adds sort feature to the household list. --------- Co-authored-by: Alireza Safaierad <frontendmonster@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sort feature to the household list.