Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) docs: improve docs for riot-rs-threads #133

Closed
wants to merge 9 commits into from

Conversation

elenaf9
Copy link
Collaborator

@elenaf9 elenaf9 commented Mar 4, 2024

Improve API documentation for riot-rs-threads and riot-rs-runqueue.
I'll work on next to extract the essence about scheduling in riot-rs into a markdown file in the book (most likely as User Guide and Developer Guide?) but I thought that it might make sense to already open this as a draft PR now.

Open Questions:

  • Should the user/developer guide be in the book/ or docs/ folder?
  • I don't fully understand Threads::flag_wait_one - @kaspar030 could you help me here?

@kaspar030
Copy link
Collaborator

  • I don't fully understand Threads::flag_wait_one - @kaspar030 could you help me here?

Threads::flag_wait_any(mask) returns when any of mask are set, and returns all of those (set & mask). Threads::flag_wait_one(mask) returns when any of mask are set, and returns exactly one of those (ffs (set & mask)), leaving the not returned active.

This is (maybe) useful if the handler would rather handle the flags one-by-one.

@kaspar030
Copy link
Collaborator

  • Should the user/developer guide be in the book/ or docs/ folder?

Let's have them in the book. That's markdown after all. There are sections for user/developer docs already.

@ROMemories
Copy link
Collaborator

Thanks for the PR! I left a few comments; some of them come from our newly introduced Coding conventions, not all code comply with them yet, but new code and refactorings should

@elenaf9 elenaf9 marked this pull request as draft March 4, 2024 13:15
@kaspar030
Copy link
Collaborator

Maybe it makes sense to split this PR into smaller chunks - maybe one per crate and one for the book?

@elenaf9
Copy link
Collaborator Author

elenaf9 commented Mar 6, 2024

Maybe it makes sense to split this PR into smaller chunks - maybe one per crate and one for the book?

Good idea.

Closing this PR in favor of #149, #150 and #152

@elenaf9 elenaf9 closed this Mar 6, 2024
@elenaf9 elenaf9 deleted the doc/threads-scheduling branch May 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants