chore: clippy-lint the coapcore crate #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
commented
Aug 5, 2024
| @@ -130,6 +130,10 @@ impl<Crypto: lakers::Crypto> Default for SecContextState<Crypto> { | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| #[expect( | |||
| clippy::large_enum_variant, | |||
| reason = "having no allocator, we cannot add a level of indirection" | |||
There was a problem hiding this comment.
Can we do something about it or is my reason correct?
|
@chrysn I was careful when making the changes recommended by clippy, but could you still check them? |
- Add the crate to the list of clippy-linted crates. - Fix most of the warnings.
ROMemories
force-pushed
the
chore/clippy-lint-coapcore
branch
from
3bd12bf
to
9774f58
Compare
|
If it's alright with you I'd rather apply those to #348 than merge them here; this would be very prone to merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues/PRs references
Depends on #376
Open Questions
None
Change checklist