Bump nightly to 2024-10-21 #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: fix(runqueue): uptdate RunQueueIter impl lifetimes to current nightly: s/uptdate/update/ |
kaspar030
force-pushed
the
bump-nightly-2024-10-21
branch
from
fdac9e0
to
f0bc926
Compare
ROMemories
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Testing with the hello-world example:
espressif-esp32-c6-devkitc-1works as expectedrpi-pico-wdoes not compile, there is anotheroptions(noreturn)to remove (I'm not sure why CI is not catching that)nrf52840dkcompiles but hard-faults in hardware
Haven't tested other examples or other architectures.
| @@ -102,7 +102,6 @@ unsafe extern "C" fn PendSV() { | |||
| bx LR | |||
| ", | |||
| sched = sym sched, | |||
| options(noreturn) | |||
There was a problem hiding this comment.
I couldn't easily find the documentation for this removed option, but I assume this is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues/PRs references
Open Questions
Change checklist