feat(example): add a USB HID keyboard example #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
commented
Jan 12, 2024
| @@ -206,6 +233,29 @@ async fn init_task(mut peripherals: arch::OptionalPeripherals) { | |||
|
|
|||
| let spawner = Spawner::for_current_executor().await; | |||
|
|
|||
| #[cfg(feature = "usb_hid")] | |||
| { | |||
| let config = embassy_usb::class::hid::Config { | |||
There was a problem hiding this comment.
We may need something similar to 1092e7c to be able to override this USB HID configuration, in particular because it is currently specific to keyboards.
ROMemories
commented
Jan 12, 2024
| } | ||
|
|
||
| #[cfg(feature = "usb_hid")] | ||
| pub type UsbHidReader = hid::HidReader<'static, UsbDriver, 1>; |
There was a problem hiding this comment.
Both HidReader and HidWriter need their buffer size to be configured, to accommodate the maximum HID report size, which depends on the USB speed and the type of HID device; however it is unclear how this could be made configurable by users.
ROMemories
commented
Jan 12, 2024
| poll_ms: 60, | ||
| max_packet_size: 64, | ||
| }; | ||
| // FIXME: use a proper USB HID configuration for the USB Builder |
There was a problem hiding this comment.
It would make sense to have a separate USB configuration for the HID and CDC-ECM classes.
|
This got merged with #87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.