-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework initialization #79
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
commented
Feb 17, 2024
use riot_rs::embassy::{arch::OptionalPeripherals, Spawner}; | ||
#[riot_rs::embassy::distributed_slice(riot_rs::embassy::EMBASSY_TASKS)] | ||
#[linkme(crate = riot_rs::embassy::linkme)] | ||
fn web_server_init(spawner: &Spawner, peripherals: &mut OptionalPeripherals) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here, b/c the Buttons peripherals are optional, I found it easier to just write a custom non-async init function.
kaspar030
commented
Feb 17, 2024
kaspar030
commented
Feb 17, 2024
ROMemories
requested changes
Feb 19, 2024
kaspar030
force-pushed
the
pr/rework_initialization
branch
from
February 19, 2024 11:47
ff72168
to
effca47
Compare
kaspar030
force-pushed
the
pr/rework_initialization
branch
from
February 19, 2024 13:41
effca47
to
0697048
Compare
This was referenced Feb 19, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks (and hopefully simplifies) task initialization.
With
SendCell
andDelegate
I think we got the tools to not use a trait (object) for initialization.I'm pretty happy so far, it feels like much reduced boilerplate already.
For now the PR:
Application
traitDrivers
andInitializationArgs
SendCell
, a struct that helps passing around non-Send types, runtime-checking that an object stays on the same executorriot_rs::embassy::network_stack()
, which is now used to get to the network stackStack
object instead of passing it through theDrivers
structDelegate
, which can be used to provide hooks e.g., for theUsbBuilder
Delegate
to provide a hook into theUsbBuilder
Delegate
I'm aware that this is a pretty large PR as is. I'll split it up once we agree on the direction.