feat: add condition property to proposition - #75
Merged
Conversation
close #72 * add `schema_id` and `maturity` class methods to va models * include `$id` and `maturity` metadata in `model_json_schema`
korikuzma
commented
Aug 18, 2026
korikuzma
changed the title
korikuzma
marked this pull request as ready for review
August 27, 2026 21:17
Contributor
nah that's fine. I typically treat these objects as immutable anyway |
jsstevenson
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #67
@jsstevenson I originally implemented the setter method, but removed it because at least in downstream projects I use, I haven't had a need. Is this something that you actively do and would benefit from? If so, I can add.