Fix bug with error state writing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaffo
reviewed
Jul 31, 2024
| @@ -716,10 +717,14 @@ func TestProcessor_Serialization(t *testing.T) { | |||
| State[MyAppContext, MyOverallContext, MyJobContext]{ | |||
| TriggerState: TRIGGER_STATE_NEW, | |||
| Exec: func(ctx context.Context, ac MyAppContext, oc MyOverallContext, jc MyJobContext) (MyJobContext, string, []KickRequest[MyJobContext], error) { | |||
| if jc.Count == 1 { | |||
| return jc, STATE_DONE, nil, errors.New("errored again") | |||
There was a problem hiding this comment.
to confirm that if multiple errors are detected, they are recorded separately and don't clobber each other. You can see this assertion lower in the test case
gaffo
reviewed
Jul 31, 2024
| // Execute the job | ||
| rtn := Return[JC]{ | ||
| PriorState: j.State, | ||
| PriorState: priorState, |
There was a problem hiding this comment.
Is there a test that catches this bug?
There was a problem hiding this comment.
The updated test case does
gaffo
reviewed
Jul 31, 2024
| @@ -716,10 +717,14 @@ func TestProcessor_Serialization(t *testing.T) { | |||
| State[MyAppContext, MyOverallContext, MyJobContext]{ | |||
| TriggerState: TRIGGER_STATE_NEW, | |||
| Exec: func(ctx context.Context, ac MyAppContext, oc MyOverallContext, jc MyJobContext) (MyJobContext, string, []KickRequest[MyJobContext], error) { | |||
| if jc.Count == 1 { | |||
| return jc, STATE_DONE, nil, errors.New("errored again") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors were not being added to the state file