-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tools/varvamp from version 1.2.0 to 1.2.1 #6372
Conversation
There are new updates, they have been integrated to the PR, check the file diff. |
4fb395b
to
b9b410a
Compare
@jonas-fuchs, you changed the FASTA header line to include varVAMP- and dropped more specific information instead. Was this intended? |
@bgruening Which info do you mean? I mainly changed the bed file format to be artic compatible and included that you can name your scheme. Indeed some information is lost in the main outputs, but e.g. the primer names and penalties you still have this info in the tsv and primer all files. |
Test are failing here for example because of that diff
|
Renaming of the fasta header was intended. The name of the file hasn t changed giving the info which consensus it is. Sry about the trouble 😅 |
@@ -53,7 +53,7 @@ results/ | |||
#end if | |||
#if $mode.m_select == 'tiled' and $mode.scheme_outputs and 'primer_dimers' in $mode.scheme_outputs: | |||
## ensure the unsolvable_primer_dimers.tsv file, which varVAMP creates only conditionally, exists in all cases, in which we try to discover it as an output | |||
&& cp -n dimers_fallback.tsv results/unsolvable_primer_dimers.tsv | |||
&& cp --update=none dimers_fallback.tsv results/unsolvable_primer_dimers.tsv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a warning before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what was the warning? Cannot find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything else looks easy enough to fix :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That -n is deprecated and I should use the long version
There are new updates, if you want to integrate them, close the PR and delete branch. |
handled in #6486 |
Hello! This is an automated update of the following tool: tools/varvamp. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.
I have updated tools/varvamp from version 1.2.0 to 1.2.1.
Project home page: https://github.com/jonas-fuchs/varVAMP/releases
For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.
If you want to skip this change, close this PR without deleting the branch. It will be reopened if another change is detected.
Any commit from another author than 'planemo-autoupdate' will prevent more auto-updates.
To ignore manual changes and allow autoupdates, delete the branch.