Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/varvamp from version 1.2.0 to 1.2.1 #6372

Closed

Conversation

gxydevbot
Copy link
Collaborator

Hello! This is an automated update of the following tool: tools/varvamp. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/varvamp from version 1.2.0 to 1.2.1.

Project home page: https://github.com/jonas-fuchs/varVAMP/releases

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

If you want to skip this change, close this PR without deleting the branch. It will be reopened if another change is detected.

Any commit from another author than 'planemo-autoupdate' will prevent more auto-updates.

To ignore manual changes and allow autoupdates, delete the branch.

@gxydevbot
Copy link
Collaborator Author

There are new updates, they have been integrated to the PR, check the file diff.

@bgruening
Copy link
Member

@jonas-fuchs, you changed the FASTA header line to include varVAMP- and dropped more specific information instead. Was this intended?

@jonas-fuchs
Copy link

jonas-fuchs commented Oct 5, 2024

@bgruening Which info do you mean? I mainly changed the bed file format to be artic compatible and included that you can name your scheme. Indeed some information is lost in the main outputs, but e.g. the primer names and penalties you still have this info in the tsv and primer all files.

@bgruening
Copy link
Member

Test are failing here for example because of that diff

Output ambiguous_consensus:  different than expected, difference (using diff):
( /tmp/tmp2ak5l8smambiguous_consensus.fasta v. /tmp/tmpgu9586ieambiguous_consensus.fasta )
--- local_file
+++ history_data
@@ -1,2 +1,2 @@
->ambiguous_consensus
+>varVAMP_consensus
 tatcccgtrtycaractgayatccttattaayytgatgcaaccycgrcagcttgtkttccgrccygaagtyytstggaaycayccgatccagcgrgtyatacataatgagctggagcartactgccgwgcycgygctggycgytgyctkgargtkggsgcycayccaagatcyatyaatgayaacccyaatgtyytgcaccggtgcttyctycgcccggtyggdagagaygtmcagcgytggtaytcygccccsacycgyggyccagcggcyaaytgccgccgytcygcgctacgyggyytgccccctgtcgaycgyacmtaytgcttcgacgggttytcccgctgcgcytttgccgctgagacyggratygctttataytcactrcatgacctytggccytcggaygtygcggaggcya

@jonas-fuchs
Copy link

Renaming of the fasta header was intended. The name of the file hasn t changed giving the info which consensus it is. Sry about the trouble 😅

@@ -53,7 +53,7 @@ results/
#end if
#if $mode.m_select == 'tiled' and $mode.scheme_outputs and 'primer_dimers' in $mode.scheme_outputs:
## ensure the unsolvable_primer_dimers.tsv file, which varVAMP creates only conditionally, exists in all cases, in which we try to discover it as an output
&& cp -n dimers_fallback.tsv results/unsolvable_primer_dimers.tsv
&& cp --update=none dimers_fallback.tsv results/unsolvable_primer_dimers.tsv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a warning before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, what was the warning? Cannot find it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks easy enough to fix :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That -n is deprecated and I should use the long version

@gxydevbot
Copy link
Collaborator Author

There are new updates, if you want to integrate them, close the PR and delete branch.

@wm75 wm75 mentioned this pull request Oct 24, 2024
5 tasks
@wm75
Copy link
Contributor

wm75 commented Oct 24, 2024

handled in #6486

@wm75 wm75 closed this Oct 24, 2024
@bgruening bgruening deleted the tools/varvamp branch October 26, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants