Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin many galaxy packages for lint workflow #59

Merged
merged 4 commits into from
Apr 29, 2024
Merged

pin many galaxy packages for lint workflow #59

merged 4 commits into from
Apr 29, 2024

Conversation

cat-bro
Copy link
Collaborator

@cat-bro cat-bro commented Apr 4, 2024

This is the arrangement we are using on Galaxy Australia at the moment to enable the linting workflow to run. It's important that PR's to tools.yml have the linting check so I'm unwilling to merge any at the moment.

This is the arrangement we are using on Galaxy Australia at the moment to enable the linting workflow to run. It's important that PR's to tools.yml have the linting check so I'm unwilling to merge any at the moment.
@cat-bro cat-bro requested a review from nuwang April 4, 2024 01:21
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0 was released yesterday and that includes the bug fixes for the missing packages, can we use that?

@cat-bro
Copy link
Collaborator Author

cat-bro commented Apr 4, 2024

If this is fixed then it's unnecessary to change this file, and requiring galaxy-app should be enough.

I reran the checks on a PR that failed lint, and it still fails after installing galaxy-app-24.0.0 galaxy-auth-24.0.0 galaxy-config-24.0.0 galaxy-data-24.0.0 galaxy-files-24.0.0 galaxy-job-execution-24.0.0 galaxy-job-metrics-24.0.0 galaxy-navigation-24.0.0 galaxy-objectstore-24.0.0 galaxy-sequence-utils-1.1.5 galaxy-tool-util-24.0.0 galaxy-tours-24.0.0 galaxy-util-24.0.0 galaxy-web-framework-24.0.0 galaxy-web-stack-24.0.0, this PR: #58

@nuwang nuwang merged commit a606427 into main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants