-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProteoRE tool 'get_unique_peptide_srm_method' #591
base: master
Are you sure you want to change the base?
ProteoRE tool 'get_unique_peptide_srm_method' #591
Conversation
@bgruening we are all set on our side for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Human_SRM_atlas_2016-04.csv is super big. Does it really need to be shipped with the tool, or should the admin download it on demand? Will this file change over time? Can we compress it?
--features='$protein_features' | ||
--output='$output' | ||
|
||
#if "SRM_atlas" in str($srm_file).split("/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could do a string search with if "/SRM_atlas/" in $srm_file I guess
tools/proteore_get_unique_peptide_srm_method/proteore_get_unique_peptide_SRM-MRM_method.xml
Show resolved
Hide resolved
<tests> | ||
<test> | ||
<conditional name="input" > | ||
<param name="ids" value="file"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a second test for the text input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
tools/proteore_get_unique_peptide_srm_method/proteore_get_unique_peptide_SRM-MRM_method.xml
Outdated
Show resolved
Hide resolved
tools/proteore_get_unique_peptide_srm_method/proteore_get_unique_peptide_SRM-MRM_method.xml
Outdated
Show resolved
Hide resolved
…ake compressed ref file as input
Thanks Björn, this file does not change over time. I gziped it and lade modifications in the wrapper (loc file) and Python script to take gzip csv file as input. |
<param name="header" value="true" /> | ||
<param name="ncol" value="c1"/> | ||
</conditional> | ||
<param name="srm_file" value="tool-data/Human_SRM_atlas_2016-04.csv.gz" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wired. I would assume the value
needs to be the key/id from the datatable. E.g. 9979839599
?
</conditional> | ||
<param name="srm_file" type="select" label="Release" > | ||
<options from_data_table="proteore_human_srm_atlas"> | ||
<filter type="sort_by" column="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we realy want to sort for the ID column? E.g. 9979839599
... what is this number? Should we sort for column 1?
Another ProteoRE tool ; this one is 'get_unique_peptide_srm_method'
Thanks for the review !
Still 16 tools to come ...