-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cardinal Version 3.4.3 #763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two technical comments from my side.
tools/cardinal/classification.xml
Outdated
<description>spatial classification of mass spectrometry imaging data</description> | ||
<macros> | ||
<import>macros.xml</import> | ||
</macros> | ||
<expand macro="requirements"> | ||
<requirement type="package" version="2.3">r-gridextra</requirement> | ||
<requirement type="package" version="3.3.5">r-ggplot2</requirement> | ||
<!--requirement type="package" version="2.3">r-gridextra</requirement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just remove instead of comment. git
stores it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, updated it accordingly :)
</expand> | ||
<command detect_errors="exit_code"> | ||
<![CDATA[ | ||
#for $i, $infile in enumerate($infiles): | ||
#if $infile.ext == 'imzml' | ||
ln -s '${infile.extra_files_path}/imzml' infile_${i}.imzML && | ||
ln -s '${infile.extra_files_path}/ibd' infile_${i}.ibd && | ||
cp '${infile.extra_files_path}/imzml' infile_${i}.imzML && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is copying really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately yes, otherwise neither imzml nor analyze75 files will be loaded
tools/cardinal/data_exporter.xml
Outdated
@@ -1,4 +1,4 @@ | |||
<tool id="cardinal_data_exporter" name="MSI data exporter" version="@VERSION@.0"> | |||
<tool id="cardinal_data_exporter" name="MSI data exporter" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add also a profile="22.05" to each tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added the profile to all tools 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot!
This PR updates Cardinal to version 3.4.3.