Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

including builder_example in docs/ #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

including builder_example in docs/ #2

wants to merge 2 commits into from

Conversation

MalteJ
Copy link
Member

@MalteJ MalteJ commented Jun 17, 2023

Fixes #1

@gardener-robot
Copy link
Contributor

@MalteJ Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 17, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 17, 2023
@gardener-robot
Copy link
Contributor

@Vincinator, @nkraetzschmar, @gehoern You have pull request review open invite, please check

Vincinator
Vincinator requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@Vincinator Vincinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about how we distribute the script required to use the builder.

Copying them from a documentation is not the best idea

docs/example/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not copy the files also in docs/example, this would introduce duplicates (e.g. build and docs/example/build).

Question is: How do I update the build script in gardenlinux/gardenlinux/build with latest changes from gardenlinux/builder/build?

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jun 21, 2023
@Akendo
Copy link
Contributor

Akendo commented Sep 5, 2024

@MalteJ is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincinator Vincinator Vincinator requested changes

@gehoern gehoern Awaiting requested review from gehoern

@nkraetzschmar nkraetzschmar Awaiting requested review from nkraetzschmar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needs documentation
4 participants
@MalteJ @gardener-robot @Akendo @Vincinator