-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the mailing option and updated the icons #233
base: main
Are you sure you want to change the base?
Conversation
@nitinjaiswal7537 Seems like you didn't test anything. The email is not centred w.r.t the icon, click on email takes us to some non-existing web-page instead of opening an email client, hover effect on email doesn't work, the logo on contact us side banner looks really odd (there was absolutely no need to change that... For phone icon, you can use |
Hey @garg3133 sorry for the mistake but the hovering option is not showing its result despite using different alternative there my be some technical issue by my side and also the alignment task. |
@nitinjaiswal7537 The hover effect is not working because hover-effect of For centring the email w.r.t. icon, I had shared some tips with you in the very first PR, if I remember correctly. You may try those out. |
Hey @garg3133 here are the few alternatives i had tried |
Where have you put the |
No no i have assign a tag with the email class.
Have a look over this code. |
With this code also, both the alternatives you suggested won't work.
|
Hey @garg3133 i have tried the above alternative it still not reflecting any changes. |
Well, I used the following HTML:
and the following CSS:
and it's working fine for me. |
@garg3133 I think there should surely ne some kind of technical issue by my side . So how about i commit by making all the changes you suggest and then commit them. |
Okay @nitinjaiswal7537, you can do that. But how would you be able to test those changes? Maybe try hard-reloading your page ( Also, don't forget about other changes I suggested. |
Enhanced the mailing option and have updated the mail and calling icons