LambdaFunctionArn shouldn't be suffixed with the environment in the S3 event source #80
Conversation
When configuring the S3 bucket event the function `add` builds the `LambdaFunctionConfigurations` which specifies the `LambdaFunctionArn`. The ARN should be the functions *exact* ARN and not suffixed by the environment ex.`arn:aws:lambda:us-west-1:1234567890123:function:bigquery_commit:main-env`. It makes the Lambda UI and the S3 event sources UI confused as they don't recognize that the specific Lambda function even exists. The reason why I made this change is because I had problems applying the bucket event cross-account and could not do this without this change.
|
+1 +1 +1! Please merge and publish ASAP! Related to |
iserko
changed the title
|
@Miserlou this only tackled the S3 event source and not the SNS event source as specified in Miserlou/Zappa#225 (amended the title because of it) ... we'd need to extend this into all the event sources to fix that specific issue |
|
@iserko can you do that? |
|
@josegonzalez do you have any comments on how versioning is done at the moment? |
|
From the code, it looks like S3 is the only odd one out, all the other event sources behave like the PR already. |
|
@Miserlou hah you're right 😄 @josegonzalez this should be fine to merge as it basically brings it in sync with the rest of the event sources |
|
This change was introduced by #75
In what way was it a bug? |
|
Bump! Any reason this can't be merged? |
|
@Miserlou I'm happy for this to be merged ... up to @josegonzalez |
|
Can we get a 6.0.1? :-) @josegonzalez |
When configuring the S3 bucket event the function
addbuilds theLambdaFunctionConfigurationswhich specifies theLambdaFunctionArn. The ARN should be the functions exact ARN and not suffixed by the environment ex.arn:aws:lambda:us-west-1:1234567890123:function:bigquery_commit:main-env.It makes the Lambda UI and the S3 event sources UI confused as they don't recognize that the specific Lambda function even exists.
The reason why I made this change is because I had problems applying the bucket event cross-account and could not do this without this change.
Update: ok I see that anything that comes after the function ARN is a version and/or alias http://docs.aws.amazon.com/lambda/latest/dg/versioning-aliases-permissions.html ... just means that the UI can't handle these
Comments about this?