reject updates with wrong hash

gasp-xyz · Sep 23, 2024 · e37b836 · e37b836
1 parent 247a5db
commit e37b836
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/pallets/rolldown/rpc/src/lib.rs b/pallets/rolldown/rpc/src/lib.rs
@@ -1,5 +1,5 @@
-// Copyright (C) 2021 Mangata team
 
+// Copyright (C) 2021 Mangata team
 use jsonrpsee::{
 	core::{async_trait, Error as JsonRpseeError, RpcResult},
 	proc_macros::rpc,

diff --git a/pallets/rolldown/src/lib.rs b/pallets/rolldown/src/lib.rs
@@ -409,6 +409,7 @@ pub mod pallet {
 		FerryHashMismatch,
 		MintError,
 		AssetRegistrationProblem,
+		UpdateHashMishmatch,
 	}
 
 	#[pallet::config]
@@ -488,7 +489,8 @@ pub mod pallet {
 		) -> DispatchResult {
 			let sequencer = ensure_signed(origin)?;
 
-			let update_hash = requests.abi_encode_hash();
+			let hash = requests.abi_encode_hash();
+			ensure!( update_hash == hash, Error::<T>::UpdateHashMishmatch);
 
 			Self::update_impl(sequencer, requests)
 		}

diff --git a/pallets/rolldown/src/tests.rs b/pallets/rolldown/src/tests.rs
@@ -110,6 +110,25 @@ fn process_single_deposit() {
 	});
 }
 
+
+#[test]
+#[serial]
+fn test_reject_update_with_wrong_hash() {
+	ExtBuilder::new().execute_with_default_mocks(|| {
+		forward_to_block::<Test>(36);
+		let update = L1UpdateBuilder::default()
+			.with_requests(vec![L1UpdateRequest::Deposit(Default::default())])
+			.build();
+
+
+		assert_err!(
+			Rolldown::update_l2_from_l1(RuntimeOrigin::signed(ALICE), update, H256::zero()),
+			Error::<Test>::UpdateHashMishmatch
+		);
+
+	});
+}
+
 #[test]
 #[serial]
 fn l2_counter_updates_when_requests_are_processed() {