Georust: use one big prepared geometry #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix deps
This reverts commit a2c6f42.
michaelkirk
reviewed
Jul 15, 2024
|
|
||
| use geos::{CoordSeq, Geom, Geometry, PreparedGeometry}; | ||
| use geo::{point, Contains, Geometry, MultiPolygon, Point, Polygon, PreparedGeometry, Relate}; |
There was a problem hiding this comment.
This is a great test case! I'm curious how the perf cares for your use case with geo vs. geos.
(I'll take a look at your PR soon!)
There was a problem hiding this comment.
Thanks! I didnt get to work further on the pr yet.
gauteh
changed the title
gauteh
force-pushed
the
georust-prepared
branch
from
c8ba5f1
to
9a6268b
Compare
gauteh
force-pushed
the
georust-prepared
branch
from
9a6268b
to
00b0292
Compare
gauteh
changed the title
|
Unlikely to work on its own: georust/geo#1198 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #27.
Fixes #26 , #25.
PreparedGeometryto speed up repeatedRelateoperations. georust/geo#1197