Deprecate ign_create_docs, ign_create_packages, ign_configure_build #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
11 tasks
scpeters
approved these changes
May 11, 2022
| # NOTE: This will be called automatically by ign_create_core_library(~) and | ||
| # ign_add_component(~), so users of ignition-cmake should not call this | ||
| # NOTE: This will be called automatically by gz_create_core_library(~) and | ||
| # gz_add_component(~), so users of ignition-cmake should not call this |
There was a problem hiding this comment.
this change is out of sequence, but it's not a big deal since it will change soon anyway
| # NOTE: This will be called automatically by ign_create_core_library(~) and | ||
| # ign_add_component(~), so users of ignition-cmake should not call this | ||
| # NOTE: This will be called automatically by gz_create_core_library(~) and | ||
| # gz_add_component(~), so users of ignition-cmake should not call this |
There was a problem hiding this comment.
this change is out of sequence, but it's not a big deal since it will change soon anyway
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#250 was getting too large. This PR migrates 3 functions.
Each commit migrates one function.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸