Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign -> gz] Migrate more internal variables #263

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

chapulina
Copy link
Contributor

Summary

All these variables should be internal to gz-cmake, so they can be changed without tick-tocking. I verified that by building the entire stack on top of this branch, and also by searching for these variables in other libraries.

Test it

  • CI should pass
  • The entire stack should build locally on top of this branch

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 24, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 24, 2022
@chapulina chapulina merged commit 59a926a into main May 27, 2022
@chapulina chapulina deleted the chapulina/3/internal_ign branch May 27, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants