Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign to gz] Deprecate IGN_GUI_PLUGIN_PATH in favor of GZ_GUI_PLUGIN_PATH #384

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Rename the environment variable with a tick-tock cycle.

Test it

Try out the hello_pluginin examples/plugin/hello_plugin:

$ GZ_GUI_PLUGIN_PATH=`pwd`/build ign gui -s HelloPlugin -v 2
# Loads the plugin without warnings.
$ IGN_GUI_PLUGIN_PATH=`pwd`/build ign gui -s HelloPlugin -v 2
[GUI] [Wrn] [Application.cc:454] Found plugin [HelloPlugin] using deprecated environment variable [IGN_GUI_PLUGIN_PATH]. Please use [GZ_GUI_PLUGIN_PATH] instead.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Apr 12, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #384 (af46151) into main (966c73a) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   64.12%   64.11%   -0.01%     
==========================================
  Files          45       45              
  Lines        5508     5518      +10     
==========================================
+ Hits         3532     3538       +6     
- Misses       1976     1980       +4     
Impacted Files Coverage Δ
src/Application.cc 84.82% <71.42%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfb596...af46151. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

src/Application.cc Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants