udpdate to kfactory09 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ def bend_circular( | |||
| width: Width of the core. [um] | |||
| radius: Radius of the backbone. [um] | |||
| layer: Layer index of the target layer. | |||
| enclosure: :py:class:`kfactory.utils.Enclosure` object to describe the | |||
| enclosure: :py:class:`kfactory.enclosure` object to describe the | |||
There was a problem hiding this comment.
Should be kfactory.enclosure.KCellEnclosure or kfactory.enclosure.LayerEnclosure
kgeneric/__init__.py
Outdated
| from kgeneric.tech import TECH | ||
|
|
||
| cells_dict = get_cells([gpdk]) | ||
| pdk = Pdk(name="generic", cell_factories=cells_dict, layers=LAYER) | ||
| kf.kcl.cells = cells |
There was a problem hiding this comment.
Doesn´t exist anymore. This should be factories, and you need to make sure they are using the right KCLayout object to instantiate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to update to latest kfactory 0.9.0
needs some fixing
@SkandanC
@sebastian-goeldi