Refactor related to "EMF model driven development of Jakarta RESTful OSGi applications" #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juergen-albert
This PR contains partial refactor of
DTOToEPackageConverter
code, related to "EMF model driven development of Jakarta RESTful OSGi applications" project you assigned to me.Since
DTOToEPackageConverter
started off as a static utility class, adding another converter,JavaReferenceTypeToEPackageConverter
, which shares and builds upon most of that logic, necessitated extracting common parts as to avoid code duplication. That is one the points I mentioned during requirements elicitation phase for "EMF model driven development of Jakarta RESTful OSGi applications" project.Unfortunately, since static methods cannot be overriden, I was unable to continue using this approach - i.e. having both converters be static utility classes and avoid duplicating most of the code.
Therefore, I created a new PR ( #61 ) on a separate branch (
Converter-as-Singleton-Component
), which continues with this refactor using a different approach, which allows to easily share common logic. Please refer to that PR ( #61 ) for more details and let me know whether you insist on continuing using static utility class approach, as this will unfortunately require duplicating most of the code - unless you have some other idea which can reconcile this, that perhaps I did not take into consideration.