Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ListItemView #39

Closed
gemdev111 opened this issue Jun 5, 2024 · 0 comments · Fixed by #40
Closed

Refactor ListItemView #39

gemdev111 opened this issue Jun 5, 2024 · 0 comments · Fixed by #40
Assignees
@gemdev111

Comments

@gemdev111
Copy link
Contributor

Refactoring ListItemView component
@gemdev111 gemdev111 self-assigned this Jun 5, 2024
gemdev111 added a commit that referenced this issue Jun 6, 2024
@gemdev111
Project strucuture update
876e0fc 
TextStyle moved from Components package to Style package, added necessary Style package imports to Gem
ListItemView minor change

Done #39
@gemdev111 gemdev111 mentioned this issue Jun 6, 2024
Merged
@gemdev111 gemdev111 linked a pull request Jun 6, 2024 that will close this issue
Refactor list item view #40
Merged
gemdev111 added a commit that referenced this issue Jun 6, 2024
@gemdev111
Transaction state fix (#41)
911a77a 
* Refactored ListItemView,
added previews with different states, moved ListItemVIew to Lists folder

* Project structure updated
moved ListItemProgressView from ListItemView, since it has more then 1 dependency.  Also used in TransactionsScene separately
TextStyle moved from Components package to Style package, added necessary Style package imports to Gem
ListItemView minor change

Done #39

* fixed pbroj, unlinked files after vsc

* Added simple previews to TransactionView
Fixing preview crashing by updating AssetId.binance in App-Configuration

* Fixed: #10 Transaction state does not always fit

* Removed unused comments
ListItemValue moved to Lists folder as seprate file
ListSection moved to Lists folder
gemcoder21 added a commit that referenced this issue Jun 11, 2024
@gemdev111 @gemcoder21
Add search functionality #18 (#42)
76a2205 
* Refactored ListItemView, added previews with different states
moved ListItemVIew to Lists folder

* moved ListItemProgressView from ListItemView, since it has more then 1 dependecy.  Also used in TransactionsScene separetly

* Project strucuture update
TextStyle moved from Components package to Style package, added necessary Style package imports to Gem
ListItemView minor change

Done #39

* fixed pbroj, unlinked files after vsc

* Search added for netwroks #18(NetworkSelectorNavigationStack) TODO: - empty state

* added preview for NetworkSelectorNavigationStack

* empty view updated, empty view applied to networkselector empty view

* empty view added as overlay

* updated state view to support exisiting empty view

* removed comments, removed hardcodede localizable

* localisation updates

* added no chains found

* refactor->rename StateEmptyView.message to title

* State empty view updates
- added TextValueView's for easier text handling
- added `footnote`  font if only title injected

* Localisation updates

* ImportWalletType scene updated EmptyState title

* Added search to ChainListSettingsScene

* added constraint if no image and no description change title font to regular

* removed comments

* Refactored ListItemView & Text Style added defaults value
ListItemView decorated with TextValueView instead of combo text & stle
Added defaults values for TextStyle, Added TextStyle.Preview - to have ability see colors in packages previews

* added note to TextStyle

* Updated Gem dependency with style init

* Project structure update
refactor->rename TextValueView to TextValue
Crated Types folder, moved Value Types(not views) to Types

* Moved System Image to Styles
Added necessary imports Style, removed SystemImage.infoCircle. Since it's repeated image and we don't need it

* State emptyview updated with TextValueViw

* added necessary import

* added necessary import, updated State empty view with new Style

* Updated init StateEmptyView
#18 DONE

* updated default init of State Empty view with TextStyle static values

* updated initi method with clearer init, added missed values to init

* Update localize

* Updated preview mock chain

* if let changed to a new flow

* apr text style updated to correct callout

* Asset Configuration re-indention

* Added SearchableListView to components
Rename file ChainSettings to ChainSettingsScene
Rename file ChainListSettings to ChainListSettingsScene

* Updates ChainListSettingsScene to support new search
Updates in SearchableListView

* Updates to search flow

SearchableListView update
Added ChainFilterable protocol to omit bipolare code
Updated viewmodels to support new ChainFilterable
Updated NetworkSelectorNavigationStack, added model
AddTokenScene updated ( added address and chain to view model, actions separated in view )

* refactoring ChainFilterable

* Updates AddTokenScene

* ChainListSettingsScene fixed var -> let
AddTokenViewModel added value to MARK

---------

Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gemdev111 gemdev111

Labels
None yet
Projects
Gem Wallet - (iOS, Android, Core)
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor list item view gemwalletcom/gem-ios
1 participant
@gemdev111