Refactor list item view #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved ListItemVIew to Lists folder
…1 dependecy. Also used in TransactionsScene separetly
TextStyle moved from Components package to Style package, added necessary Style package imports to Gem ListItemView minor change Done #39
Closed
gemcoder21
approved these changes
Jun 6, 2024
| let longTitleExtra = "Long Title Extra Long Title Extra Long Title Extra Long Title Extra" | ||
| let longSubtitleExtra = "Long Subtitle Extra Long Subtitle Extra Long Subtitle Extra" | ||
|
|
||
| let defaultTextStyle = TextStyle(font: Font.system(.body), color: .primary) |
There was a problem hiding this comment.
maybe add static let defaultTextStyle for ListItemView ?
then in the init function you can pass Self.defaultTextStyle as default value
| ) | ||
| } | ||
|
|
||
| // Long Text States |
There was a problem hiding this comment.
Suggested change
| // Long Text States |
| let tagTextStyleBlue = TextStyle(font: Font.system(.footnote), color: .blue, background: .blue.opacity(0.2)) | ||
|
|
||
| return List { | ||
| // Basic States |
There was a problem hiding this comment.
Suggested change
| // Basic States |
no need for such comments, it's self explanatory in the section
Conflicts: Packages/Components/Sources/Lists/ListItemView.swift
ListItemView decorated with TextValueView instead of combo text & stle Added defaults values for TextStyle, Added TextStyle.Preview - to have ability see colors in packages previews
refactor->rename TextValueView to TextValue Crated Types folder, moved Value Types(not views) to Types
Added necessary imports Style, removed SystemImage.infoCircle. Since it's repeated image and we don't need it
gemcoder21
approved these changes
Jun 8, 2024
Conflicts: Gem/Transfer/ViewsModels/ConfirmTransferViewModel.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39