-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating To GRDBQuery 0.9 #152
Conversation
Migrated requests from Queryable to ValueObservationQueryable Updates gem dependencies requests init
@@ -4,23 +4,16 @@ import GRDBQuery | |||
import Combine | |||
import Primitives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove import Combine
as well in each file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately not possible to remove for now, ref to xcode warning(ValueObservationQueryable):
Cannot use conformance of 'AnyPublisher<Output, Failure>' to 'Publisher' here; 'Combine' was not imported by this file; this is an error in Swift 6
No description provided.