Max button align fix #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> center by default [u] updated onChange iin assetlistview, old one was deprecated
gemcoder21
approved these changes
Jun 5, 2024
| .fixedSize() | ||
| HStack { | ||
| Button(Localized.Transfer.max, action: useMax) | ||
| .buttonStyle(ColorButton.lightGray(paddingHorizontal: 16, paddingVertical: 8)) |
There was a problem hiding this comment.
Instead of 16,8 use Spacing.small, Spacing.medium
| ) | ||
| } | ||
| } | ||
| .frame(maxWidth: Spacing.scene.button.maxWidth) | ||
| .frame(maxWidth: .infinity) |
There was a problem hiding this comment.
need to make sure button is not larger than Spacing.scene.button.maxWidth
There was a problem hiding this comment.
yeah. Button still fixedSize and haven't changed. The frame changed for container view for iPad to fix ipad layout for that button
| @@ -82,7 +82,7 @@ public struct AssetListItemView: View { | |||
| public var body: some View { | |||
| HStack { | |||
| imageView | |||
| HStack(alignment: .center) { | |||
| HStack { | |||
There was a problem hiding this comment.
make sure this does not break other places
There was a problem hiding this comment.
Sure. By default HStack initialise with alignment: center. HStack(alignment: .center) - not necessary to write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[f] Improve Max button position #11 #11
[~] re-indent
[~] small refactor assetlistview, removed unused alignment: .center -> center by default
[u] updated onChange iin assetlistview, old one was deprecated
attached images:
