Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #51

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Dev #51

merged 4 commits into from
Nov 6, 2023

Conversation

Lucpen
Copy link
Collaborator

@Lucpen Lucpen commented Nov 6, 2023 •
edited by jemten
Loading

PR checklist

  • Release 1.0.0
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

lucia.pena.perez@scilifelab.se added 2 commits November 2, 2023 13:47
@Lucpen Lucpen requested a review from jemten as a code owner November 6, 2023 08:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cd90ccd

+| ✅ 129 tests passed       |+
#| ❔ 258 tests were ignored |#
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in tomte.nf: change this to use the plugin nf-validation
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/genomic-medicine-sweden/tomte/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/nf-core/tomte/master/nextflow_schema.json

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-06 09:28:32

jemten
jemten reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mainly a comment that version 1 feels better than version 0.1 😆

subworkflows/local/alignment.nf Outdated Show resolved Hide resolved
subworkflows/local/prepare_references.nf Show resolved Hide resolved
subworkflows/local/alignment.nf Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
assets/multiqc_config.yml Outdated Show resolved Hide resolved
Lucpen and others added 2 commits November 6, 2023 10:23
@Lucpen @jemten
Update subworkflows/local/alignment.nf
91e7ea0 
Co-authored-by: Anders Jemt <jemten@users.noreply.github.com>
@Lucpen @jemten
Apply suggestions from code review
cd90ccd 
Co-authored-by: Anders Jemt <jemten@users.noreply.github.com>
jemten
jemten approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄 🎁 🎅 ❤️

@Lucpen Lucpen merged commit 963eb95 into master Nov 6, 2023
12 checks passed
@Lucpen Lucpen deleted the dev branch November 6, 2023 10:14
@Lucpen Lucpen restored the dev branch November 6, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemten jemten jemten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucpen @jemten