Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat updated igenomes.config #76

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat updated igenomes.config #76

merged 4 commits into from
Mar 6, 2024

Conversation

Lucpen
Copy link
Collaborator

@Lucpen Lucpen commented Mar 6, 2024 •
edited
Loading

PR checklist

  • Modified igenomes config
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Lucpen Lucpen requested a review from jemten as a code owner March 6, 2024 09:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e60e708

+| ✅ 153 tests passed       |+
#| ❔ 317 tests were ignored |#
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-06 10:59:01

@Lucpen Lucpen linked an issue Mar 6, 2024 that may be closed by this pull request
Add custom genome config file instead of igenomes #64
Closed
jemten
jemten reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a small note in the usage documentation on how to utilise this? Looks solid otherwise

@Lucpen Lucpen requested a review from jemten March 6, 2024 10:21
jemten
jemten approved these changes Mar 6, 2024
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@Lucpen Lucpen merged commit 233e190 into dev Mar 6, 2024
4 checks passed
@Lucpen Lucpen deleted the genome_config_file branch March 6, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemten jemten jemten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom genome config file instead of igenomes
2 participants
@Lucpen @jemten