Mino feat explore thumbnail #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for geo-tone-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jlaurentpdx
requested changes
May 2, 2022
There was a problem hiding this comment.
Awesome work, Minoka! I added some comments for appreciation and requested changes - summary here:
App.jsxappears to have been duplicated into the root folder fromsrc; this should get removed.- The avatars rendered on the Explore page currently read "image" by screen readers; let's add an empty
alttag to have that bypassed.
| @@ -33,6 +33,7 @@ export default function Explore() { | |||
| key={`project.title${index}`} | |||
| onClick={() => handleExploreProject(project.projectId)} | |||
| > | |||
| <img className={styles.thumbnail} src={project.avatar} /> | |||
There was a problem hiding this comment.
We should include an empty alt tag here (alt="") to prevent the image from being read by screen readers.
| @@ -0,0 +1,73 @@ | |||
| import { BrowserRouter as Router, Routes, Route } from 'react-router-dom'; | |||
There was a problem hiding this comment.
App.jsx should exist in the src folder, but it appears that it may have accidentally been duplicated into the root folder here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the avatar to render correctly on the font-end. but this pull request must be made in tandem with the back end.
---> look at the backend PR for more details.