-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mino feat explore thumbnail #46
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for geo-tone-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, Minoka! I added some comments for appreciation and requested changes - summary here:
App.jsx
appears to have been duplicated into the root folder fromsrc
; this should get removed.- The avatars rendered on the Explore page currently read "image" by screen readers; let's add an empty
alt
tag to have that bypassed.
@@ -33,6 +33,7 @@ export default function Explore() { | |||
key={`project.title${index}`} | |||
onClick={() => handleExploreProject(project.projectId)} | |||
> | |||
<img className={styles.thumbnail} src={project.avatar} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include an empty alt
tag here (alt=""
) to prevent the image from being read by screen readers.
@@ -0,0 +1,73 @@ | |||
import { BrowserRouter as Router, Routes, Route } from 'react-router-dom'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App.jsx
should exist in the src
folder, but it appears that it may have accidentally been duplicated into the root folder here.
I got the avatar to render correctly on the font-end. but this pull request must be made in tandem with the back end.
---> look at the backend PR for more details.