#10158 painless accessibility improvements #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 4, 2024 11:23
On Behalf of DB Systel
Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake. On Behalf of DB Systel
- Convert heading that, semantically, should not be a heading, to a div - correctly assign label to scalebox - add alt tag to attribution logo On Behalf of DB Systel
1 task
tdipisa
added
External Contribution
enhancement
BackportNeeded
|
@fkellner thank you so much for your contribution. We will review as soon as possible. |
tdipisa
removed
the
BackportNeeded
allyoucanmap
requested changes
Jul 4, 2024
There was a problem hiding this comment.
@fkellner thanks for the contribution, most of the changes are good, there is just to review how we set the lang in the Localized component
| @@ -37,6 +37,7 @@ class Localized extends React.Component { | |||
| if (typeof children === 'function') { | |||
| children = children(); | |||
| } | |||
| document.documentElement.setAttribute("lang", this.props.locale); | |||
There was a problem hiding this comment.
It would be better to move this in componentDidMount and componentDidUpdate and remove it from the render method, it could be something like:
componentDidMount() {
this.updateDocumentLangAttribute();
}
componentDidUpdate(prevProps) {
if (this.props.locale !== prevProps.locale) {
this.updateDocumentLangAttribute();
}
}
updateDocumentLangAttribute() {
if (document?.documentElement) {
document.documentElement.setAttribute("lang", this.props.locale);
}
}
There was a problem hiding this comment.
Thanks for the helpful review! Sorry for taking so long, I no longer work at DB Systel.
As requested, the document language is now set when the component is mounted or the language is changed instead of with every rerender.
fkellner
force-pushed
the
feat_10158_painless_accessibility_improvements
branch
from
b05cd29
to
375292a
Compare
|
@fkellner is this PR ready for a new review then? Thank you so much. |
tdipisa
added
the
BackportNeeded
|
Yes, I did the requested changes and it is ready from my side |
allyoucanmap
approved these changes
Sep 13, 2024
|
@ElenaGallo please test on dev and let me know if we can backport on 2024.02.xx, thanks |
|
Test passed, @allyoucanmap please backport on 2024.02.xx. Thanks |
allyoucanmap
pushed a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 16, 2024
…ns-it#10159) * geosolutions-it#10158: set HTML document language On Behalf of DB Systel * geosolutions-it#10158: re-enable browser zoom Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake. On Behalf of DB Systel * geosolutions-it#10158: Tiny Accessibility Fixes - Convert heading that, semantically, should not be a heading, to a div - correctly assign label to scalebox - add alt tag to attribution logo On Behalf of DB Systel * geosolutions-it#10158: set HTML document language once per mount/update As requested, the document language is now set when the component is mounted or the language is changed instead of with every rerender. --------- Co-authored-by: Florian Kellner <florian.fl.kellner@deutschebahn.com>
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Sep 16, 2024
* #10158: set HTML document language On Behalf of DB Systel * #10158: re-enable browser zoom Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake. On Behalf of DB Systel * #10158: Tiny Accessibility Fixes - Convert heading that, semantically, should not be a heading, to a div - correctly assign label to scalebox - add alt tag to attribution logo On Behalf of DB Systel * #10158: set HTML document language once per mount/update As requested, the document language is now set when the component is mounted or the language is changed instead of with every rerender. --------- Co-authored-by: fkellner <mr.florian.kellner@posteo.de> Co-authored-by: Florian Kellner <florian.fl.kellner@deutschebahn.com>
offtherailz
pushed a commit
that referenced
this pull request
Oct 18, 2024
* #10158: set HTML document language On Behalf of DB Systel * #10158: re-enable browser zoom Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake. On Behalf of DB Systel * #10158: Tiny Accessibility Fixes - Convert heading that, semantically, should not be a heading, to a div - correctly assign label to scalebox - add alt tag to attribution logo On Behalf of DB Systel * #10158: set HTML document language once per mount/update As requested, the document language is now set when the component is mounted or the language is changed instead of with every rerender. --------- Co-authored-by: Florian Kellner <florian.fl.kellner@deutschebahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny changes that improve accessibility. Should hopefully not take longer than a minute to review.
What kind of change does this PR introduce?
Issue
What is the current behavior?
#10158
Bad Lighthouse Accessibility Score
What is the new behavior?
Better Lighthouse Accessibility Score through:
Breaking change
Does this PR introduce a breaking change?
Other useful information
Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible for people who need larger controls than
disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming
into the map using browser zoom should be able to notice the actual controls and recover from their mistake.