Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded geostory URL issue with scroll position #10369

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Igi-ID
Copy link
Contributor

@Igi-ID Igi-ID commented May 29, 2024

Description

Added section component to url on init of geostory, when scroll position is enabled.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#9047

What is the new behavior?
When user enables Include scroll position flag, the /section/id component of the url is properly added.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@Igi-ID Igi-ID added this to the 2024.01.02 milestone May 29, 2024
@Igi-ID Igi-ID self-assigned this May 29, 2024
@Igi-ID Igi-ID linked an issue May 29, 2024 that may be closed by this pull request
@tdipisa tdipisa requested review from dsuren1 and removed request for offtherailz and tdipisa May 29, 2024 13:58
@tdipisa
Copy link
Member

tdipisa commented May 29, 2024

@Igi-ID why this PR is still in draft? Please specify the status here.

@Igi-ID
Copy link
Contributor Author

Igi-ID commented May 29, 2024

@Igi-ID why this PR is still in draft? Please specify the status here.

Embedded geostory urls when the section is specified such as geostory-embedded/<gesotoryId>/section/<sectionId> are still not fixed. The current fix just handles properly building the share url, such that

  • When a geostory is rendered and the Include scroll position flag is enabled, the shared url will contain the section
  • Scrolling through a geostory and then sharing with the flag enabled should also properly generate an url.

@tdipisa tdipisa assigned mahmoudadel54 and unassigned Igi-ID Jun 10, 2024
@tdipisa tdipisa modified the milestones: 2024.01.02, 2024.02.00 Jul 17, 2024
@tdipisa tdipisa modified the milestones: 2024.02.00, 2025.01.00 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded geostory URL issue with scroll position
3 participants