Entity submission create-as-update by logging forceProcessed in source #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktuite
force-pushed
the
ktuite/createAsUpdate
branch
from
24619df
to
087e350
Compare
2 tasks
ktuite
force-pushed
the
ktuite/createAsUpdate
branch
from
087e350
to
53a9f4e
Compare
ktuite
commented
Oct 29, 2024
| @@ -0,0 +1,20 @@ | |||
| // Copyright 2024 ODK Central Developers | |||
There was a problem hiding this comment.
Note to self: change this migration date if merging after https://github.com/getodk/central-backend/pull/1253/files (20241029-01-schedule-entity-form-upgrade-create-forms.js)
ktuite
force-pushed
the
ktuite/createAsUpdate
branch
from
53a9f4e
to
7020876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#702, also closes getodk/central#720
simplified version of PR #1232
Adds
forceProcessedflag toentity_def_sourcestable and fills it in.Uses that to check if, when failing to create an entity because of a uuid conflict, whether the root version of the entity was force-applied. If so, that suggests it's appropriate to try applying the create action as an update instead.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes