Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Postgres version requirement #973

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add Postgres version requirement #973

merged 1 commit into from
Sep 25, 2023

Conversation

lognaturel
Copy link
Member

Making this implicit requirement explicit!

@@ -4,7 +4,7 @@
[![License](https://img.shields.io/badge/license-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
[![Build status](https://circleci.com/gh/getodk/central-backend.svg?style=shield)](https://circleci.com/gh/getodk/central-backend)

ODK Central Backend is a minimal [ODK](https://getodk.org/) server based on Node.js and Postgres. It is currently under development.
ODK Central Backend is the API server for [ODK](https://getodk.org/). It's built with Node.js and Postgres.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a couple of quick cosmetic changes while here, hopefully that's ok! For better or worse, I think Central stopped being minimal a little while ago!

We used to use the "It is currently under development" language when we had some dead repos but now those have been removed.

@matthew-white
Copy link
Member

Just to document one reason why Postgres 14+ is required, @lognaturel wrote on Slack:

From @eyelidlessness about postgres 14 now being required: it’s about keywords that now can be used as column labels without AS

-- Syntax error in 12, 13
SELECT '' action;

-- No syntax error in 14+
SELECT '' as action;
SELECT '' "action";

@lognaturel lognaturel merged commit 11d9b81 into master Sep 25, 2023
4 checks passed
@lognaturel lognaturel deleted the postgres-version branch September 25, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants