Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: reject requests with unexpected Host header #747

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

nginx: reject requests with unexpected Host header #747

wants to merge 7 commits into from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 9, 2024

No description provided.

@alxndrsn alxndrsn changed the title nginx: reject HTTPS requests with unexpected Host header nginx: reject requests with unexpected Host header Oct 9, 2024
@alxndrsn alxndrsn marked this pull request as draft October 9, 2024 08:24
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 9, 2024

CircleCI build needs fixing, probably around:

docker run --network container:project-nginx-1 appropriate/curl -4 --insecure --retry 30 --retry-delay 10 --retry-connrefused https://localhost/

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 9, 2024

Sometimes CNAME is set to "local":

central/files/nginx/setup-odk.sh

Line 33 in 87bbdb3

CNAME=$( [ "$SSL_TYPE" = "customssl" ] && echo "local" || echo "$DOMAIN") \

Perhaps DOMAIN should be used in place of CNAME.

@alxndrsn alxndrsn marked this pull request as ready for review October 15, 2024 08:09
@alxndrsn alxndrsn requested a review from yanokwa October 15, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanokwa yanokwa Awaiting requested review from yanokwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alxndrsn