This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
fix: use the same output for surveys as for logs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a package variable to hold the survey output writer and a setter for it. Add a helper to generate a survey option using the writer for stdout. Initialize the survey output to be the same as for the log module.
malept
commented
Aug 30, 2023
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can use
--credential-processwith the prompts.This PR is basically Jesse's branch that he PR'd upstream, but with the "latest" changes from the default branch merged in. I tested it on Linux and it works as expected.