feat(nuxt): Make dynamic import() wrapping default #13958
Merged
+74
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
size-limit report 📦
|
darthf1
reviewed
Oct 11, 2024
packages/nuxt/src/common/types.ts
Outdated
| * Enabling basic server tracing can be used for environments where modifying the node option `--import` is not possible. | ||
| * However, enabling this option only supports limited tracing instrumentation. Only http traces will be collected (but no database-specific traces etc.). | ||
| * If this option is `false`, the Sentry SDK won't wrap the server entry file with `import()`. Not wrapping the | ||
| * server entry file will disable Sentry on the server-side. When you set this option to `true`, make sure |
There was a problem hiding this comment.
Suggested change
| * server entry file will disable Sentry on the server-side. When you set this option to `true`, make sure | |
| * server entry file will disable Sentry on the server-side. When you set this option to `false`, make sure |
I think it should say false here?
There was a problem hiding this comment.
true is correct here, but I'll rephrase the JSDoc a bit so it is less confusing :)
s1gr1d
force-pushed
the
sig/server-wrapping-default
branch
3 times, most recently
from
d211c67
to
e12c03c
Compare
s1gr1d
commented
Oct 14, 2024
packages/nuxt/src/common/types.ts
Outdated
| */ | ||
| experimental_basicServerTracing?: boolean; | ||
| dynamicImportWrapping?: boolean; |
There was a problem hiding this comment.
I am not sure about the naming here as it is quite technical but describes what it does. I thought about some other names such as autoSentryPreload (as Sentry is preloaded with this), dynamicImportForServerEntry (longer, more descriptive).
There was a problem hiding this comment.
would go with dynamicImportForServerEntry
chargome
approved these changes
Oct 15, 2024
packages/nuxt/src/common/types.ts
Outdated
| */ | ||
| experimental_basicServerTracing?: boolean; | ||
| dynamicImportWrapping?: boolean; |
There was a problem hiding this comment.
would go with dynamicImportForServerEntry
While the preset for Netlify exports the serverless handler function as
`export { D as default }`, the Vercel preset exports this handler as
`export { D as handler };`.
This PR makes some adaptions to the code generation in the plugin to
make it possible to re-export `default` functions. The previous snippet
did not work as `default` is obviously not allowed as a function name.
s1gr1d
force-pushed
the
sig/server-wrapping-default
branch
from
7a54dcd
to
f0577d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
--importflag must not be added anymore. If it is still set, the server-side will be initialized twice and this leads to unexpected errors.First merge this: #13945
Part of this: #13943
This PR makes it the default to include a rollup plugin that wraps the server entry file with a dynamic import (
import()). This is a replacement for the node--importCLI flag.If you still want to manually add the CLI flag you can use this option in the
nuxt.config.tsfile:(option name is up for discussion)