Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure release comments are not added for prereleases #13991

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 15, 2024

Noticed here: #13932 (comment) we should not add comments for prereleases 😅

@mydea mydea self-assigned this Oct 15, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Should we also ignore rc releases?

@mydea mydea enabled auto-merge (squash) October 16, 2024 19:52
Copy link

codecov bot commented Oct 16, 2024

❌ 18 Tests Failed:

Tests completed Failed Passed Skipped
633 18 615 32
View the top 3 failed tests by shortest run time
tracing/request/fetch/test.ts should create spans for fetch requests
Stack Traces | 10.1s run time
test.ts:7:11 should create spans for fetch requests
tracing/browserTracingIntegration/navigation/test.ts should create a navigation transaction on page navigation
Stack Traces | 30s run time
test.ts:7:11 should create a navigation transaction on page navigation
sessions/update-session/test.ts should update session when an error is thrown.
Stack Traces | 30s run time
test.ts:7:11 should update session when an error is thrown.

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants