-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check validity of trace- and span-id in context update from header #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 83.33% 81.78% -1.56%
==========================================
Files 53 53
Lines 6338 6363 +25
Branches 1198 1207 +9
==========================================
- Hits 5282 5204 -78
- Misses 1042 1046 +4
- Partials 14 113 +99 |
ToDo: update the docs (think it is this page) with a valid header. |
supervacuus
requested changes
Oct 4, 2024
supervacuus
approved these changes
Oct 7, 2024
I went ahead with the merge and created a docs issue as a follow-up to your todo item: getsentry/sentry-docs#11504 |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis of #1012 showed a potential way for users to send invalid trace and span id values. This can happen when a customer uses
sentry_transaction_context_update_from_header(...)
which reads a string that looks liketraceid-spanid(-sampled)?
. The only formatting that currently gets checked is whether there is a first-
.Although these are never used in an unsafe context within our code, it still makes sense to reject the invalid formats on our end rather than relying on Relay to reject them.
The formats we expect are the following (from our docs):
trace_id
= 32 hex charactersspan_id
= 16 hex charactersToDo