Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stuck crashpad_client on windows #902

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

supervacuus
Copy link
Collaborator

This also breaks CI and thus prevents the release of 0.6.7 which should contain #901

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #902 (6340bea) into master (406d418) will decrease coverage by 3.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   86.49%   82.54%   -3.96%     
==========================================
  Files          40       53      +13     
  Lines        3674     7366    +3692     
  Branches        0     1185    +1185     
==========================================
+ Hits         3178     6080    +2902     
- Misses        496     1177     +681     
- Partials        0      109     +109     

@supervacuus supervacuus merged commit 1040b51 into master Nov 10, 2023
18 of 20 checks passed
@supervacuus supervacuus deleted the fix/stuck_crashpad_client branch November 10, 2023 17:47
@supervacuus
Copy link
Collaborator Author

I merged this after the 3rd restart of the Android emulator job... because this change has nothing to do with android. The android build is failing because of GitHub infra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants