Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage improvements #12

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Homepage improvements #12

merged 8 commits into from
Jul 2, 2024

Conversation

seankross
Copy link
Contributor

Description

@tefirman @sckott @sitapriyamoorthi I added more prose to the home page but now I feel like I don't like how the homepage looks, what do ya'll think? Suggestions extremely welcome.

Related Issue

Working on #9.

@seankross seankross requested a review from sckott March 28, 2024 17:09
Copy link

@sckott
Copy link
Member

sckott commented Mar 28, 2024

I don't like how the homepage looks

Can you be more specific?

Some ideas:

  • break up the prose into sections. for example, Our Mission and Our Contribution could be broken into sections of the page more distinctly by using color/lines/etc. e.g., here https://ucsc-ospo.github.io/
  • possibly we should have a slightly bigger font size for the body text? seems kinda small

@vortexing
Copy link
Member

See issues #15 and #14 for some thoughts too!

@tefirman
Copy link
Member

Couple ideas, but obviously feel free to take or leave any of them:

  • I'm not seeing the WILDS email address anywhere, should we add that to the "Help" and/or "Get Involved" sections?
  • Might not be worth the effort of switching templates, but I wonder if the navigation bar along the top would look better as a sidebar, similar to how the contribution guide is laid out.

@sckott
Copy link
Member

sckott commented Mar 29, 2024

I wonder if the navigation bar along the top would look better as a sidebar,

I think that would make it look like a book which is okay, but I think we're going for more of a website look, yeah?

Copy link

github-actions bot commented Jul 1, 2024

Copy link

github-actions bot commented Jul 1, 2024

@seankross seankross mentioned this pull request Jul 2, 2024
@seankross
Copy link
Contributor Author

I'm much happier now with this content and layout for the homepage.

@seankross seankross requested a review from tefirman July 2, 2024 19:36
Copy link
Member

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, totally agree that this new layout looks much better! Just added a few very minor comments, feel free to take or leave them. Thanks @seankross !

index.qmd Outdated Show resolved Hide resolved
index.qmd Outdated Show resolved Hide resolved
index.qmd Outdated Show resolved Hide resolved
Co-authored-by: Taylor Firman <37599954+tefirman@users.noreply.github.com>
@seankross seankross merged commit e691838 into main Jul 2, 2024
2 checks passed
Copy link

github-actions bot commented Jul 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants