Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hutch theme #5

Draft
wants to merge 10 commits into
base: ingest-scp
Choose a base branch
from
Draft

Hutch theme #5

wants to merge 10 commits into from

Conversation

vsriram24
Copy link
Collaborator

Update the baseline Shiny app to include Fred Hutch theming / improved aesthetics

@vsriram24 vsriram24 added the enhancement New feature or request label Sep 20, 2024
@seankross
Copy link
Contributor

seankross commented Sep 23, 2024

Does work on this branch build upon your work in ingest-scp? If so, change the base branch to ingest-scp. If not, let's talk about how to make sure you're not duplicating changes across PRs. Once we establish the base branch for this PR I will give more specific comments.

@seankross
Copy link
Contributor

I like the Hutch theming! The dream of Oncarto is that anyone could grab this and spin it up for their own cancer center. I think we should separate out the Hutch theming so that the version we run here has it, but we don't force it on everyone else. Let's try to think about this creatively so that other people can look at the Hutch theming as an example for their own theming. Like can we boil the theming down to a function that we drop into the app? Or as an argument to oncarto::run_app()? Once we figure out the PR base I will have more specific suggestions.

@seankross seankross mentioned this pull request Sep 23, 2024
@seankross seankross changed the base branch from dev to ingest-scp September 23, 2024 20:58
@seankross
Copy link
Contributor

Talking to Vivek live right now! He's rightfully concerned that folks won't notice the map has changed, we should consult @codebeaker about whether we should have a loading spinner, a toast, or related to make the change apparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants