Update proofr.Rmd #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wee tweak
dtenenba
reviewed
May 20, 2024
vignettes/proofr.Rmd
Outdated
| @@ -18,7 +18,7 @@ library(proofr) | |||
|
|
|||
| ## Authenticate with the PROOF API | |||
|
|
|||
| Run the function `proof_authenticate()`, which calls the PROOF API with your username and password, and returns an API token (an alphanumeric string). | |||
| Run the function `proof_authenticate()`, which calls the PROOF API with your username and password, and returns an API token (an alphanumeric string). A new token is created when a new PROOF server is created, thus this API token will need to be reset. | |||
There was a problem hiding this comment.
This is not what happens. The token does not change. We can/should discuss whether it should, but currently it does not.
There was a problem hiding this comment.
@vortexing can you undo this text change, or change the wording to explain that the same token is returned when calling proof_authenticate
|
@vortexing So maybe this isn't super clear (I'll make it more clear), but the original file that the vignette comes from is the file |
sckott
approved these changes
Aug 5, 2024
|
Thanks @tefirman ! looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wee tweak of the vignette