Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFRS: Do idempotence in core (GSI-1091) #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TheByronHimes
Copy link
Member

Removed the IdempotenceHandler layer in the event consumer -- it was too difficult to plug all possible gaps. There's nothing more to be done in the core, it seems.
During offline discussions we talked about the scenario where a file is registered, then deleted, and then the Kafka events are replayed so the registration event (FileUploadValidationSuccess) is consumed again. This scenario should actually not happen because the event re-publish mechanism would publish the latest state of the object in the FIS. Topic compaction should also be used though if it's not already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant