Update IVA events topic name for consistency

ghga-de · May 13, 2024 · af5be39 · af5be39
1 parent 0a9672d
commit af5be39
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/.devcontainer/.dev_config.yaml b/.devcontainer/.dev_config.yaml
@@ -11,6 +11,6 @@ notification_event_type: notification
 notification_event_topic: notification_events
 file_registered_event_topic: internal_file_registry
 file_registered_event_type: file_registered
-iva_events_topic: ivas
+iva_state_changed_event_topic: ivas
 iva_state_changed_event_type: iva_state_changed
 user_events_topic: users
diff --git a/README.md b/README.md
@@ -153,7 +153,7 @@ The service requires the following configuration parameters:
   ```
 
 
-- **`iva_events_topic`** *(string)*: The name of the topic containing IVA events.
+- **`iva_state_changed_event_topic`** *(string)*: The name of the topic containing IVA events.
 
 
   Examples:

diff --git a/config_schema.json b/config_schema.json
@@ -90,12 +90,12 @@
       "title": "File Registered Event Type",
       "type": "string"
     },
-    "iva_events_topic": {
+    "iva_state_changed_event_topic": {
       "description": "The name of the topic containing IVA events.",
       "examples": [
         "ivas"
       ],
-      "title": "Iva Events Topic",
+      "title": "Iva State Changed Event Topic",
       "type": "string"
     },
     "iva_state_changed_event_type": {
@@ -227,7 +227,7 @@
     "access_request_denied_event_type",
     "file_registered_event_topic",
     "file_registered_event_type",
-    "iva_events_topic",
+    "iva_state_changed_event_topic",
     "iva_state_changed_event_type",
     "service_instance_id",
     "kafka_servers",

diff --git a/example_config.yaml b/example_config.yaml
@@ -8,7 +8,7 @@ db_name: users
 file_registered_event_topic: internal_file_registry
 file_registered_event_type: file_registered
 generate_correlation_id: true
-iva_events_topic: ivas
+iva_state_changed_event_topic: ivas
 iva_state_changed_event_type: iva_state_changed
 kafka_security_protocol: PLAINTEXT
 kafka_servers:

diff --git a/src/nos/translators/inbound/event_sub.py b/src/nos/translators/inbound/event_sub.py
@@ -59,7 +59,7 @@ class EventSubTranslatorConfig(BaseSettings):
         description="The type used for events detailing internally file registrations.",
         examples=["file_registered"],
     )
-    iva_events_topic: str = Field(
+    iva_state_changed_event_topic: str = Field(
         default=...,
         description="The name of the topic containing IVA events.",
         examples=["ivas"],
@@ -80,7 +80,7 @@ def __init__(
         self.topics_of_interest = [
             config.access_request_events_topic,
             config.file_registered_event_topic,
-            config.iva_events_topic,
+            config.iva_state_changed_event_topic,
         ]
         self.types_of_interest = [
             config.access_request_created_event_type,

diff --git a/tests/fixtures/test_config.yaml b/tests/fixtures/test_config.yaml
@@ -11,6 +11,6 @@ notification_event_type: notification
 notification_event_topic: notification_events
 file_registered_event_topic: internal_file_registry
 file_registered_event_type: file_registered
-iva_events_topic: ivas
+iva_state_changed_event_topic: ivas
 iva_state_changed_event_type: iva_state_changed
 user_events_topic: users
diff --git a/tests/test_orchestrator.py b/tests/test_orchestrator.py
@@ -322,7 +322,7 @@ async def test_iva_state_change(
     await joint_fixture.kafka.publish_event(
         payload=trigger_event.model_dump(),
         type_=joint_fixture.config.iva_state_changed_event_type,
-        topic=joint_fixture.config.iva_events_topic,
+        topic=joint_fixture.config.iva_state_changed_event_topic,
         key=TEST_USER.user_id,
     )
 
@@ -387,7 +387,7 @@ async def test_all_ivas_reset(joint_fixture: JointFixture):
     await joint_fixture.kafka.publish_event(
         payload=trigger_event.model_dump(),
         type_=joint_fixture.config.iva_state_changed_event_type,
-        topic=joint_fixture.config.iva_events_topic,
+        topic=joint_fixture.config.iva_state_changed_event_topic,
         key=f"all-{TEST_USER.user_id}",
     )