Skip to content

Commit

Permalink
Remove id_ keyword in dao.delete call
Browse files Browse the repository at this point in the history
  • Loading branch information
TheByronHimes committed May 10, 2024
1 parent 411a652 commit b114889
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions lock/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ h11==0.14.0 \
# via
# httpcore
# uvicorn
hexkit==3.0.1 \
--hash=sha256:0d854aa8c0f5539338a50ed363557d4bbf720ca01afde9f07512cb76a7be398d \
--hash=sha256:61347f4564eb557bb4dea176a0085dc85391a4a5eb32681433b7afc1487df3aa
hexkit==3.0.2 \
--hash=sha256:172c55b756ea0a5ff5e83ba97860947408a132bb37800404e6e7b1cabab9d3e7 \
--hash=sha256:d8cb77d64c6021725f6e40e87d62792e22a8928810de983f96a6ecfe9245f1f8
# via ghga-service-commons
httpcore==1.0.5 \
--hash=sha256:34a38e2f9291467ee3b44e89dd52615370e152954ba21721378a87b2960f7a61 \
Expand Down
6 changes: 3 additions & 3 deletions lock/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ h11==0.14.0 \
--hash=sha256:8f19fbbe99e72420ff35c00b27a34cb9937e902a8b810e2c88300c6f0a3b699d \
--hash=sha256:e3fe4ac4b851c468cc8363d500db52c2ead036020723024a109d37346efaa761
# via uvicorn
hexkit==3.0.1 \
--hash=sha256:0d854aa8c0f5539338a50ed363557d4bbf720ca01afde9f07512cb76a7be398d \
--hash=sha256:61347f4564eb557bb4dea176a0085dc85391a4a5eb32681433b7afc1487df3aa
hexkit==3.0.2 \
--hash=sha256:172c55b756ea0a5ff5e83ba97860947408a132bb37800404e6e7b1cabab9d3e7 \
--hash=sha256:d8cb77d64c6021725f6e40e87d62792e22a8928810de983f96a6ecfe9245f1f8
# via ghga-service-commons
httptools==0.6.1 \
--hash=sha256:00d5d4b68a717765b1fabfd9ca755bd12bf44105eeb806c03d1962acd9b8e563 \
Expand Down
2 changes: 1 addition & 1 deletion src/nos/core/orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ async def delete_user_data(self, resource_id: str) -> None:
log the fact but not raise an error.
"""
try:
await self._user_dao.delete(id_=resource_id)
await self._user_dao.delete(resource_id)
except ResourceNotFoundError:
# do not raise an error if the user is not found, just log it.
log.warning("User not found for deletion", extra={"user_id": resource_id})
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async def insert_test_data(joint_fixture: JointFixture):
await joint_fixture.user_dao.insert(TEST_USER)
yield
try:
await joint_fixture.user_dao.delete(id_=TEST_USER.user_id)
await joint_fixture.user_dao.delete(TEST_USER.user_id)
except ResourceNotFoundError:
pass

Expand Down

0 comments on commit b114889

Please sign in to comment.