Notification Updates (GSI-931)

[TheByronHimes]

Changes have been made according to feedback from Simon here.
Exceptions for the following:

• "Your data download access request has been rejected": made small change, but need to revisit later.
• "Contact Address Verification Code Transmitted": There is no public documentation that I could find.
• "IVA Unverified": It was not listed in the Sugar Ant spec that this should go to the user too, so I will revisit it later.

The config adds a mandatory helpdesk_email option, so the version is bumped to 2.0.0.

[dontseyit]

It looks good to me, the required changes are addressed as they should be.

My vote for "IVA Unverified" is to send it to the user as well, because IVAs can be unverified by the system in cases such as the renewal of the TOTP token. So, it would be better to make the user aware of this.

[coveralls]

Pull Request Test Coverage Report for Build 10598404251

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 89.164%

---

Totals
Change from base Build 9658705562:	0.03%
Covered Lines:	288
Relevant Lines:	323

---

💛 - Coveralls