generated from ghga-de/microservice-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IVA Notifications (GSI-741) #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lock files and pre-commit Remove test_user from joint fixture
Add methods to orchestrator
Cito
requested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Just a couple of small suggestions.
Pull Request Test Coverage Report for Build 8997560664Details
💛 - Coveralls |
Cito
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Two rewording suggestions, feel free to ignore if you think yours is better.
Cito
approved these changes
May 8, 2024
Co-authored-by: Christoph Zwerschke <cito@online.de>
Co-authored-by: Christoph Zwerschke <cito@online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notifications according to the sugar ant epic regarding IVA state changes.
When consuming the configured event type, the key is checked to see whether it begins with 'all-'. If so, the orchestrator's "process_all_ivas_invalidated" method is called. Otherwise, "process_iva_state_change" is called.
The process_iva_state_change method will double-check the value of the state field (only within the context of the notifications).
If all checks out, it will the call a private method corresponding to the type of notification to send.