Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbox Pattern (GSI-742) #6

Merged
merged 11 commits into from
May 13, 2024
Merged

Conversation

TheByronHimes
Copy link
Member

This adds an outbox subscriber to consume User events to be able to link a User ID to other relevant info (name, email, and academic title). It also adds a notification upon identifying changes to a user's name and/or email address.

@TheByronHimes TheByronHimes requested a review from Cito May 13, 2024 08:57
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Some minor suggestions below.

.devcontainer/.dev_config.yaml Outdated Show resolved Hide resolved
config_schema.json Outdated Show resolved Hide resolved
src/nos/core/notifications.py Outdated Show resolved Hide resolved
src/nos/core/orchestrator.py Outdated Show resolved Hide resolved
src/nos/translators/inbound/event_sub.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_orchestrator.py Outdated Show resolved Hide resolved
tests/test_outbox_subscriber.py Outdated Show resolved Hide resolved
tests/test_outbox_subscriber.py Outdated Show resolved Hide resolved
tests/test_outbox_subscriber.py Show resolved Hide resolved
Fix notification wording

Fix _changed_info docstring

Use pytestmark in test modules
@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9064081831

Details

  • 57 of 65 (87.69%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 88.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nos/main.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/nos/main.py 1 0.0%
Totals Coverage Status
Change from base Build 8997660270: -0.4%
Covered Lines: 284
Relevant Lines: 321

💛 - Coveralls

@TheByronHimes TheByronHimes requested a review from Cito May 13, 2024 13:58
@TheByronHimes TheByronHimes merged commit 2f1524b into main May 13, 2024
8 checks passed
@TheByronHimes TheByronHimes deleted the feature/outbox_pattern_GSI-742 branch May 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants